custom fields: add CERN fields and custom ID schemes #218
Conversation
kpsherva
commented
Oct 21, 2024
kpsherva
commented
- IDs: register custom schemes
* IDs: register custom schemes
| @@ -63,7 +63,7 @@ services: | |||
| environment: | |||
| # settings only for development. DO NOT use in production! | |||
| - bootstrap.memory_lock=true | |||
| - "OPENSEARCH_JAVA_OPTS=-Xms512m -Xmx512m" | |||
| - "OPENSEARCH_JAVA_OPTS=-Xms1024m -Xmx1024m" | |||
There was a problem hiding this comment.
I think this is needed only for full migration
There was a problem hiding this comment.
does it hurt to increase the memory? I like to test the full migration from time to time
| #THEME_FRONTPAGE_TEMPLATE = 'cds_rdm/frontpage.html' | ||
| #THEME_FOOTER_TEMPLATE = 'cds_rdm/footer.html' | ||
| #THEME_HEADER_TEMPLATE = 'cds_rdm/header.html' | ||
| # THEME_FRONTPAGE_TEMPLATE = 'cds_rdm/frontpage.html' |
There was a problem hiding this comment.
Not sure, it was formatting which highlighted it as chane
| @@ -214,7 +215,8 @@ from cds_rdm.oidc import ( | |||
| ) | |||
| from urllib.parse import quote | |||
|
|
|||
| CERN_KEYCLOAK_BASE_URL = os.environ.get("INVENIO_CERN_KEYCLOAK_BASE_URL", "https://keycloak-qa.cern.ch/") | |||
| CERN_KEYCLOAK_BASE_URL = os.environ.get("INVENIO_CERN_KEYCLOAK_BASE_URL", | |||
| "https://keycloak-qa.cern.ch/") | |||
There was a problem hiding this comment.
isn't that weird indentation?
There was a problem hiding this comment.
formatting was applied
| """Define validator for `custom_scheme`.""" | ||
| return { | ||
| "validator": is_aleph, | ||
| "normalizer": lambda value: value, |
There was a problem hiding this comment.
you don't have to pass this if it is the same as the default here
| "validator": is_aleph, | ||
| "normalizer": lambda value: value, | ||
| "filter": ["aleph"], | ||
| "url_generator": None, |
There was a problem hiding this comment.
| """Define validator for `custom_scheme`.""" | ||
| return { | ||
| "validator": is_inspire, | ||
| "normalizer": lambda value: value, |
There was a problem hiding this comment.
| "validator": is_inspire, | ||
| "normalizer": lambda value: value, | ||
| "filter": ["inspire"], | ||
| "url_generator": None, |
There was a problem hiding this comment.
| @@ -0,0 +1,57 @@ | |||
| import re | |||
There was a problem hiding this comment.
missing copyright and module docstring.
| field="cern:experiments", | ||
| ui_widget="AutocompleteDropdown", | ||
| display_url="https://greybook.cern.ch/experiment/list", |
There was a problem hiding this comment.
Where is this displayed?
minor: worth making it a config in case we need to change this?
